Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

including original document in case where an error is not raised but … #940

Closed

Conversation

cyberintUser1
Copy link

…returned individually

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cyberintUser1
Copy link
Author

related issue
#939

jubins and others added 9 commits April 29, 2019 14:45
…expected instead of timeout. (elastic#937)

The `timeout` parameter in docstring is misleading for following methods in elasticsearch.client.indices.py, renamed this param in query_params decorator and docstring to `request_timeout`:

1. create
2. open
3. close
4. delete
5. put_mapping
6. put_alias
7. update_aliases
8. delete_alias
9. put_template
10. delete_template
11. shrink
12. rollover
* Update cat.py to have correct query params

* Add missing api remote_info and missing params

* a couple apis have had added query params

* Add Split api and add missing query params

* Adding processor_grok api

* Adding missing apis:
* update by query rethrottle
* scripts painless execute
* scripts painless context
* rank eval

* delete by query rethrottle

* add missing query params

* Add missing xpack apis

* Update helpers to account for 7.x scroll api
* Added equality check for Connection class

* ES: make connection hashable
@fxdgear
Copy link
Contributor

fxdgear commented May 17, 2019

jenkins please test this

fxdgear and others added 4 commits May 21, 2019 21:21
…ic#957)

* add cloud_id

* adding doc strings

* update changelog

* adding some tests to check for cloud_id

* update the read me
* ml client has not method _bulk_body

Need to access the _bulk_body method from the client object

closes: elastic#959

* update changelog too
@cyberintUser1
Copy link
Author

didn't understand you answer

@fxdgear
Copy link
Contributor

fxdgear commented Jun 5, 2019

Jenkins year this please

1 similar comment
@fxdgear
Copy link
Contributor

fxdgear commented Jun 5, 2019

Jenkins year this please

@Winterflower
Copy link

Jenkins test this please

@cyberintUser1
Copy link
Author

can we merge?

Camilla and others added 3 commits July 16, 2019 22:47
Pass scroll and scroll_id in the request body instead of as query params in scan
@viglia viglia requested review from viglia and honzakral December 11, 2019 15:26
@viglia viglia self-assigned this Dec 11, 2019
@honzakral
Copy link
Contributor

Thank you for this PR, this is a good addition but needs tests as it is very important functionality. Ideally the test would also cover corner cases like people passing in data as string. @viglia do you want to take a stab at those tests?

@viglia
Copy link

viglia commented Dec 11, 2019

@honzakral yes!

cyberintUser1 and others added 3 commits December 13, 2019 10:34
…1/elasticsearch-py into bugfix/include_original_doc
This commit adds the tests for the patch provided with pr elastic#940 which allows to returna document when an error
is not raised.

Two tests have been added in test_server/test_helpers.py

1. test_return_docs_when_not_raising_errors: test the mentioned patch and passing json docs
2. test_return_docs_when_not_raising_errors_passing_docs_as_strings: like the previous one but passing serialized json docs as strings
@viglia viglia mentioned this pull request Dec 13, 2019
@sethmlarson
Copy link
Contributor

I think I'm going to close this as "out of date", if you'd still like this merged you'd likely have to update in quite a few places for 8.0.

@sethmlarson sethmlarson closed this Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.