Make helpers examples runnable #2483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removing the double index instructoins
adding the client definition since ```bulk``` and ```es``` were used without context / definition changed from es to client to stay consistent with the quickstart naming convention
|
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
pquentin
reviewed
Mar 22, 2024
docs/sphinx/helpers.rst
Outdated
|
|
||
| .. code-block:: python | ||
|
|
||
| from elasticsearch import Elasticsearch, helpers |
There was a problem hiding this comment.
Any reason to import helpers here? Do we use it anywhere?
There was a problem hiding this comment.
We don't; I just wanted to have at least one example of importing the rest of them, other than bulk?
But we can also skip this one
There was a problem hiding this comment.
Yes it seems weird if we don't use it. Either we call helpers.bulk or we drop this IMO.
pquentin
reviewed
Mar 26, 2024
Co-authored-by: Quentin Pradet <[email protected]>
pquentin
approved these changes
Mar 26, 2024
pquentin
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Mar 26, 2024
Co-authored-by: Quentin Pradet <[email protected]> (cherry picked from commit 8a97cc1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding examples of how to import the helpers;
adding the client definition since
bulkandeswere usedwithout context / definition
changed from es to client to stay consistent with the quickstart naming convention