Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore .ci/make.sh file #2437

Merged
merged 4 commits into from
Feb 15, 2024
Merged

Restore .ci/make.sh file #2437

merged 4 commits into from
Feb 15, 2024

Conversation

pquentin
Copy link
Member

This file was removed by mistake in #2345.

Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Member

@picandocodigo picandocodigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We talked about moving this file to .github after migrating to Buildkite, since we wouldn't need the .ci folder anymore. The automations already check for make.sh in .github, so it should work like before.

@pquentin
Copy link
Member Author

pquentin commented Feb 13, 2024

Great point, thanks! I had forgotten about this. Done, please take another look.

Copy link
Member

@picandocodigo picandocodigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Occurrences of .ci need to be replaced by .github (or .buildkite in the case of Dockerfile in line 117) in the script. Other than that LGTM 👍

@pquentin
Copy link
Member Author

Another good catch! Tested with .github/make.sh assemble 8.12.0 this time (since codegen requires a token). Please take another look.

@pquentin pquentin merged commit 6a96e38 into elastic:main Feb 15, 2024
11 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 15, 2024
(cherry picked from commit 6a96e38)
github-actions bot pushed a commit that referenced this pull request Feb 15, 2024
(cherry picked from commit 6a96e38)
pquentin added a commit that referenced this pull request Feb 16, 2024
(cherry picked from commit 6a96e38)

Co-authored-by: Quentin Pradet <[email protected]>
pquentin added a commit that referenced this pull request Feb 16, 2024
(cherry picked from commit 6a96e38)

Co-authored-by: Quentin Pradet <[email protected]>
iuliaferoli pushed a commit to iuliaferoli/elasticsearch-py that referenced this pull request Mar 24, 2024
@pquentin pquentin deleted the restore-make-sh branch November 6, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants