-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore .ci/make.sh file #2437
Restore .ci/make.sh file #2437
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We talked about moving this file to .github
after migrating to Buildkite, since we wouldn't need the .ci
folder anymore. The automations already check for make.sh
in .github
, so it should work like before.
Great point, thanks! I had forgotten about this. Done, please take another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Occurrences of .ci
need to be replaced by .github
(or .buildkite
in the case of Dockerfile in line 117) in the script. Other than that LGTM 👍
Another good catch! Tested with |
(cherry picked from commit 6a96e38)
(cherry picked from commit 6a96e38)
(cherry picked from commit 6a96e38) Co-authored-by: Quentin Pradet <[email protected]>
(cherry picked from commit 6a96e38) Co-authored-by: Quentin Pradet <[email protected]>
This file was removed by mistake in #2345.