Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add body field parameters to 'search' API #1686

Merged
merged 1 commit into from
Aug 18, 2021
Merged

Conversation

sethmlarson
Copy link
Contributor

@sethmlarson sethmlarson commented Aug 17, 2021

Demos the deprecations of positional arguments and the body parameter. These won't be merged now but in 7.16 are likely.

TODO:

  • Figure out a generic way of passing body field parameters in REST API tests
  • Add test cases for new query_params behavior
  • Modify documentation to use new parameters if applicable
  • Contribute all missing descriptions to the search API in elasticsearch-specification

References:

@sethmlarson sethmlarson force-pushed the search-body-fields branch 8 times, most recently from 78ae114 to a815c87 Compare August 18, 2021 21:01
@sethmlarson sethmlarson merged commit 889edc9 into 7.x Aug 18, 2021
@sethmlarson sethmlarson deleted the search-body-fields branch August 18, 2021 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant