API key Authentication #1010
Merged
API key Authentication #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honzakral
reviewed
Sep 19, 2019
honzakral
suggested changes
Sep 19, 2019
There was a problem hiding this comment.
left some minor changes and one blocker - we cannot ignore a parameter that someone passed in, we need to override the defaults o raise an exception when invalid combination of parameters is defined.
The best solution for the authorization header would be to allow for multiple values which is a valid approach in http
honzakral
approved these changes
Sep 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a simplified usage of Elasticsearch's API Key authentication.