Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indices.create doesn't support include_type_name request parameter #901

Closed
dliappis opened this issue Feb 7, 2019 · 2 comments
Closed

Comments

@dliappis
Copy link
Contributor

dliappis commented Feb 7, 2019

indices.create supports wait_for_active_shards however, the recent Elasticsearch commit: elastic/elasticsearch#38270 forces the use of ?include_type_name=true to allow use of the _doc type in 7.0. Types are deprecated in 7.0 and will be completely removed in 8.0.

So for users sticking to _doc for the lifetime of 7.0, it's necessary to pass this query/parameter.

It'd be great if support for this would be added. To avoid having to follow up future parameters, would it make sense to just allow passing any arbitrary parameters that the user elects to?

@dliappis
Copy link
Contributor Author

dliappis commented Feb 7, 2019

To avoid having to follow up future parameters, would it make sense to just allow passing any arbitrary parameters that the user elects to?

To close this, specifying params={} allows passing arbitrary parameters -- serialization needs to be done by the user though, so best used only for strings. Thanks @honzakral .

@apeters
Copy link
Contributor

apeters commented Apr 16, 2019

This parameter (include_type_name) doesn't seem to be documented like the others (eg: wait_for_active_shards). Should it be?
I know this issue is closed, but it seemed like the most appropriate place for it.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants