Support mapping runtime fields #5230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If they do the might use it for inference of indices or types, or they are simply typed wrong! |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 5, 2021
* Add support for mapping runtime fields * Add missing XML comment for PIT
github-actions bot
pushed a commit
that referenced
this pull request
Jan 5, 2021
* Add support for mapping runtime fields * Add missing XML comment for PIT
stevejgordon
added a commit
that referenced
this pull request
Jan 6, 2021
* Add support for mapping runtime fields * Add missing XML comment for PIT Co-authored-by: Steve Gordon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to map runtime fields on CREATE index and PUT mapping requests. Support for searches using runtime fields will follow in another PR.
@Mpdreamz I made RuntimeFieldsDescriptor non-generic as it doesn't need anything from TDocument. This seems to work fine but I noticed that some other descriptors are generic without accessing
Tso I wanted to check if this is problematic here?Contributes to #5198