Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search enhancement: pinned queries #4143

Merged
merged 4 commits into from
Oct 15, 2019
Merged

Search enhancement: pinned queries #4143

merged 4 commits into from
Oct 15, 2019

Conversation

Mpdreamz
Copy link
Member

Copy link
Contributor

@russcam russcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Left a comment about supporting types that implicitly convert to Id

src/Nest/QueryDsl/Specialized/Pinned/PinnedQuery.cs Outdated Show resolved Hide resolved
@Mpdreamz Mpdreamz merged commit 2c125f3 into 7.x Oct 15, 2019
Mpdreamz added a commit that referenced this pull request Oct 15, 2019
* Search enhancement: pinned queries

Addresses elastic/elasticsearch#44345

* update docs in test

* remove params overloads on Ids that already convert to Ids

* add note to IdsQuery
@Mpdreamz
Copy link
Member Author

merged to master

@Mpdreamz Mpdreamz deleted the feature/7.x/pinned-queries branch October 15, 2019 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants