Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Snapshot Lifecycle Management APIs #4126

Merged
merged 3 commits into from
Oct 14, 2019
Merged

Implement Snapshot Lifecycle Management APIs #4126

merged 3 commits into from
Oct 14, 2019

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Oct 10, 2019

This commit implements the Snapshot Lifecycle APIs in both the high level and low level clients.
Unit tests for URLs, integration tests for the SLM API flow.

The slm.get_lifecycle JSON spec is patched so that policy_id is a list and the Ids type is used to model multiple ids.

This commit implements the Snapshot Lifecycle APIs in both the high level and low level clients.
Unit tests for URLs, integration tests for the SLM API flow.

The slm.get_lifecycle JSON spec is patched so that policy_id is a list and the Ids type is used to model multiple ids.
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM

src/Tests/Tests/XPack/Slm/SlmUrlTests.cs Outdated Show resolved Hide resolved
@russcam russcam merged commit 28444dd into 7.x Oct 14, 2019
russcam added a commit that referenced this pull request Oct 14, 2019
This commit implements the Snapshot Lifecycle APIs in both the high level and low level clients.
Unit tests for URLs, integration tests for the SLM API flow.

The slm.get_lifecycle JSON spec is patched so that policy_id is a list and the Ids type is used to model multiple ids.

(cherry picked from commit 28444dd)
@russcam
Copy link
Contributor Author

russcam commented Oct 14, 2019

ported to master

@Mpdreamz Mpdreamz deleted the feature/slm-apis branch November 6, 2019 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants