Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max_docs to ReindexOnServer API #4071

Merged
merged 2 commits into from
Sep 4, 2019
Merged

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Sep 3, 2019

  • Add MaximumDocuments to ReindexOnServer API and deprecate Size
  • Add MaximumDocuments and support for SlicedScroll to UpdateByQuery and DeleteByQuery

Relates: #4001

This commit adds MaximumDocuments property to ReindexOnServer API and deprecates Size.
This commit adds support for Slice and MaximumDocuments to UpdateByQuery and
DeleteByQuery APIs
Copy link
Contributor

@codebrain codebrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@russcam russcam merged commit 898a5b9 into 7.x Sep 4, 2019
russcam added a commit that referenced this pull request Sep 4, 2019
* Add max_docs and slice to ReindexOnServer,UpdateByQuery,DeleteByQuery APIs

Relates: #4001

This commit

- adds MaximumDocuments property to ReindexOnServer API and deprecates Size.
- adds support for Slice and MaximumDocuments to UpdateByQuery and
DeleteByQuery APIs

(cherry picked from commit 898a5b9)
@russcam
Copy link
Contributor Author

russcam commented Sep 4, 2019

ported to master

@Mpdreamz Mpdreamz deleted the deprecation/reindex-max-docs branch November 6, 2019 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants