Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wildcard and prefix interval rules #4060

Merged
merged 7 commits into from
Aug 30, 2019
Merged

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Aug 30, 2019

Relates: #4001

This commit adds wildcard and prefix rules support to the Intervals query.
Neither wildcard or prefix rules support filters, so a new IIntervalsNoFilter interface
is introduced for these rules. Added TODO to consolidate rules in 8.0

Relates: #4001

This commit adds wildcard and prefix rules support to the Intervals query.
Neither wildcard or prefix rules support filters, so a new IIntervalsNoFilter interface
is introduced for these rules. Added TODO to consolidate rules in 8.0
Copy link
Contributor

@codebrain codebrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor suggestions

@russcam russcam merged commit c26530b into 7.x Aug 30, 2019
russcam added a commit that referenced this pull request Aug 30, 2019
* Add wildcard and prefix interval rules

Relates: #4001

This commit adds wildcard and prefix rules support to the Intervals query.
Neither wildcard or prefix rules support filters, so a new IIntervalsNoFilter interface
is introduced for these rules. Added TODO to consolidate rules in 8.0

Co-Authored-By: Stuart Cam <[email protected]>
(cherry picked from commit c26530b)
@russcam
Copy link
Contributor Author

russcam commented Aug 30, 2019

ported to master

@russcam russcam deleted the feature/wildcard-intervals branch September 1, 2019 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants