Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Rare Terms aggregation #4054

Merged
merged 1 commit into from
Aug 30, 2019
Merged

Implement Rare Terms aggregation #4054

merged 1 commit into from
Aug 30, 2019

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Aug 28, 2019

Relates: #4001

This commit implements the Rare terms aggregations. Rare term buckets only expose key and doc_count, so a new RareTermsBucket type is used.

@russcam
Implement Rare Terms aggregation
26df354 
Relates: #4001

This commit implements the Rare terms aggregations. Rare term buckets only expose key and doc_count, so a new RareTermsBucket<TKey> type is used.
codebrain
codebrain approved these changes Aug 30, 2019
View reviewed changes
Copy link
Contributor

@codebrain codebrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@russcam russcam merged commit 5c43f5b into 7.x Aug 30, 2019
russcam added a commit that referenced this pull request Aug 30, 2019
@russcam
Implement Rare Terms aggregation (#4054)
2fbd3d8 
Relates: #4001

This commit implements the Rare terms aggregations. Rare term buckets only expose key and doc_count, so a new RareTermsBucket<TKey> type is used.

(cherry picked from commit 5c43f5b)
@russcam russcam deleted the feature/rare-terms branch September 1, 2019 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebrain codebrain codebrain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@russcam @codebrain