Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement adjust_offsets on word delimiter graph token filter #3934

Merged
merged 8 commits into from
Jul 15, 2019

Conversation

codebrain
Copy link
Contributor

@codebrain codebrain commented Jul 9, 2019

Allow word_delimiter_graph_filter to not adjust internal offsets

elastic/elasticsearch#36699

russcam and others added 8 commits July 4, 2019 14:57
This commit updates the ScoreFunctionJsonFormatter to serialize only the
script inside of the script_score JSON object.

Fixes #3904

(cherry picked from commit ac60472)
This commit adds the time zone information for a DateTime within a DateMath type, when the DateTimeKind is Local or Utc. This behaviour aligns 7.x with 6.x.

Introduce StringBuilderCache for caching a StringBuilder per thread. Use of this can be extended in a later commit.

Fixes #3899
This commit changes the HttpConnection to not set Content on HttpRequestMessage when there is no PostData. The check is performed inside of Request and RequestAsync to avoid creating any content instance and allocations.

Pass RequestData through to _onStreamAvailable delegates so that HttpCompression, ConnectionSettings and PostData can be accessed on the passed instance.

Fixes #3907

(cherry picked from commit 90c2bf7)
This commit provides support for numbers with an exponent when reading WKT.

Fixes #3920

(cherry picked from commit 8386d4c)
This commit adds script_score query support to the high level client

Closes #3843

(cherry picked from commit a474194)
This commit removes track_total_hits as a query string parameter on a search request and instead defines it in the body, allowing track_total_hits to work with individual search requests in multi search API.

Closes #3906

(cherry picked from commit 75317ec)
@codebrain codebrain mentioned this pull request Jul 9, 2019
17 tasks
Copy link
Contributor

@russcam russcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

  • Could there be a brief description or link to the elasticsearch issue/PR? This saves needing to go to the meta issue, find the item, then find the elasticsearch issue/PR link.
  • Could this be based against master rather than 7.1 branch, then ported to 7.1?

@russcam russcam changed the base branch from 7.1 to master July 11, 2019 01:16
@russcam russcam merged commit e410ac9 into master Jul 15, 2019
russcam pushed a commit that referenced this pull request Jul 15, 2019
This commit implements adjust_offsets on word delimiter graph token filter

(cherry picked from commit e410ac9)
russcam pushed a commit that referenced this pull request Jul 18, 2019
This commit implements adjust_offsets on word delimiter graph token filter

(cherry picked from commit e410ac9)
codebrain added a commit that referenced this pull request Jul 19, 2019
This commit implements adjust_offsets on word delimiter graph token filter

(cherry picked from commit e410ac9)
@russcam russcam deleted the feature/7.1/adjust-offsets branch July 24, 2019 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants