Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Obsolete AllField and IndexField #3918

Merged
merged 1 commit into from
Jul 9, 2019
Merged

Obsolete AllField and IndexField #3918

merged 1 commit into from
Jul 9, 2019

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Jul 4, 2019

This commit obsoletes the AllField and IndexField. Both should have been removed in 7.x but were missed.
Remove the DataMemberAttribute and add IgnoreDataMemberAttribute so that any value is not
sent in a request.

Fixes #3905

@russcam russcam mentioned this pull request Jul 4, 2019
Closed
codebrain
codebrain approved these changes Jul 8, 2019
View reviewed changes
Copy link
Contributor

@codebrain codebrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@russcam
Obsolete AllField and IndexField
f3c780a 
This commit obsoletes the AllField and IndexField. Both should have been removed in 7.x but were missed.
Remove the DataMemberAttribute and add IgnoreDataMemberAttribute so that any value is not
sent in a request.

Fixes #3905
@russcam
Copy link
Contributor Author

russcam commented Jul 9, 2019

rebased on top of master and force pushed.

@russcam russcam merged commit c4ed49d into master Jul 9, 2019
russcam added a commit that referenced this pull request Jul 9, 2019
@russcam
Obsolete AllField and IndexField (#3918)
8abfe06 
This commit obsoletes the AllField and IndexField. Both should have been removed in 7.x but were missed.
Remove the DataMemberAttribute and add IgnoreDataMemberAttribute so that any value is not
sent in a request.

Fixes #3905

(cherry picked from commit c4ed49d)
@russcam
Copy link
Contributor Author

russcam commented Jul 9, 2019

ported to 7.1: 8abfe06

russcam added a commit that referenced this pull request Jul 18, 2019
@russcam
Obsolete AllField and IndexField (#3918)
e2224a9 
This commit obsoletes the AllField and IndexField. Both should have been removed in 7.x but were missed.
Remove the DataMemberAttribute and add IgnoreDataMemberAttribute so that any value is not
sent in a request.

Fixes #3905

(cherry picked from commit c4ed49d)
codebrain pushed a commit that referenced this pull request Jul 19, 2019
@russcam
Obsolete AllField and IndexField (#3918)
b2093c4 
This commit obsoletes the AllField and IndexField. Both should have been removed in 7.x but were missed.
Remove the DataMemberAttribute and add IgnoreDataMemberAttribute so that any value is not
sent in a request.

Fixes #3905

(cherry picked from commit c4ed49d)
@russcam russcam deleted the fix/3905 branch July 24, 2019 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebrain codebrain codebrain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeMappingDescriptor<T> still supports setting AllField
2 participants
@russcam @codebrain