Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dictionary serialization tests #3878

Merged
merged 3 commits into from
Jun 26, 2019
Merged

Dictionary serialization tests #3878

merged 3 commits into from
Jun 26, 2019

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Jun 26, 2019

This PR adds additional dictionary serialization tests, aligning serialization behaviour in 7.x to that of 6.x

This commit adds additional unit tests for (I)(ReadOnly)Dictionary<TKey, TValue> and (I)IsADictionary<TKey, TValue>, to assert key name casing and null value behaviour for serialization
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests were a big help validating!

@Mpdreamz Mpdreamz merged commit b2c8a29 into 7.x Jun 26, 2019
@Mpdreamz Mpdreamz deleted the fix/3853 branch June 26, 2019 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants