Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete Indices Upgrade APIs #3865

Merged
merged 1 commit into from
Jun 24, 2019
Merged

Delete Indices Upgrade APIs #3865

merged 1 commit into from
Jun 24, 2019

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Jun 24, 2019

This commit deletes the Indices Upgrade APIs. Both the GET and POST versions of the API are not useful since the upgrade from 2.x to 5.x and will be removed from the REST specs. Taking the opportunity now to remove them in 7.x .NET clients.

Closes #3854

@russcam
Delete Indices Upgrade APIs
9570c7e 
This commit deletes the Indices Upgrade APIs. Both the GET and POST versions of the API are not useful since the upgrade from 2.x to 5.x and will be removed from the REST specs. Taking the opportunity now to remove them in 7.x .NET clients.

Closes #3854
@Mpdreamz
Copy link
Member

One test failure:

[xUnit.net 00:00:16.3040902]     Tests.CodeStandards.Responses.ResponsePropertyCollectionsShouldBeReadOnly [FAIL]
Failed   Tests.CodeStandards.Responses.ResponsePropertyCollectionsShouldBeReadOnly
Error Message:
 Expected collection to be empty, but found {"Elasticsearch.Net.DynamicDictionary.Keys is of type ICollection`1", "Elasticsearch.Net.DynamicDictionary.Values is of type ICollection`1"}.
Stack Trace:
   at FluentAssertions.Execut

Is already addressed in a different PR.

Mpdreamz
Mpdreamz approved these changes Jun 24, 2019
View reviewed changes
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥 good ratio of removals/additions 😸

@Mpdreamz Mpdreamz merged commit 00665d2 into 7.x Jun 24, 2019
@Mpdreamz Mpdreamz deleted the fix/3854 branch June 24, 2019 06:50
@russcam russcam mentioned this pull request Jun 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mpdreamz Mpdreamz Mpdreamz approved these changes

Assignees
No one assigned
Labels
Breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@russcam @Mpdreamz