Return of net461 #3831
Merged
Return of net461 #3831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russcam
reviewed
Jun 21, 2019
- Reintroduced HttpWebRequestConnection, this makes the sync paths on full framework not rely on GetAwaiter() which is no good in environments with synchronization context (asp.net on full framework) - reintroduced net461 as TFM also better for packaging, net461 relies on automagically including a whole bunch of system packages which is annoying to end users - tests now run net461 tests on windows - net461 support through multi targeting pack meaning you can build develop on the net461 targets from linux/osx as well
…or Elasticsearch.Net
Mpdreamz
force-pushed
the
feature/7.x/net-tfm
branch
from
0dabac8
to
45937a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reintroduced
HttpWebRequestConnection, this makes the sync paths on full framework notrely on
GetAwaiter()which is no good in environments with synchronization context (asp.net on full framework)reintroduced
net461asTFMalso better for packaging,
net461relies on auto-magically including a whole bunch of system packages which is annoying to end userstests now run
net461tests on windowsnet461support through multi targeting packmeaning you can build develop on the
net461targets fromlinux/osxas well