Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add index name to ICreateIndexResponse #3827

Merged
merged 2 commits into from
Jun 20, 2019
Merged

Add index name to ICreateIndexResponse #3827

merged 2 commits into from
Jun 20, 2019

Conversation

codebrain
Copy link
Contributor

Fixes #3823

Port to 7.x requires attention to new serialiser attributes.

russcam
russcam suggested changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@russcam russcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a small comment

src/Tests/Tests/Indices/IndexManagement/CreateIndex/CreateIndexApiTests.cs Outdated Show resolved Hide resolved
russcam
russcam approved these changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@russcam russcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Mpdreamz Mpdreamz merged commit 4123f41 into 6.x Jun 20, 2019
@Mpdreamz Mpdreamz deleted the fix/3823 branch June 20, 2019 12:05
@russcam
Copy link
Contributor

russcam commented Jun 24, 2019

@codebrain Does this need to be ported to 7.x?

@codebrain
Copy link
Contributor Author

@russcam Yes. Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russcam russcam russcam approved these changes

Assignees
No one assigned
Labels
backport main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codebrain @russcam @Mpdreamz