Feature/7.x/upgrade helper #3822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we want a more generalized name for the package e.g. |
|
Decided to rename to |
Mpdreamz
commented
Jun 19, 2019
Mpdreamz
force-pushed
the
feature/7.x/upgrade-helper
branch
from
112d6e7
to
59c3ebd
Compare
codebrain
approved these changes
Jun 24, 2019
Mpdreamz
force-pushed
the
feature/7.x/upgrade-helper
branch
2 times, most recently
from
07368f0
to
43f24d6
Compare
…readonly collection, added as exception
…rsion specific build for `Nest.7xUpgradeAssistant` its already version specific
…ich canary does but it sometimes selects netstandard2.0 which for tests is not a configured framework updated
Mpdreamz
force-pushed
the
feature/7.x/upgrade-helper
branch
from
43f24d6
to
dde9485
Compare
|
No integration test failures on netcoreapp but failed to start on net461 which is fixed #3887 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
NEST.7xUpgradeHelperpackage. Intended to be released with the7.0.0GA release.We can remove it after the
GAreleased during the 7.0 timeline, this is just intended as a one off release.Referencing this nuget package will reintroduce the methods that have been moved on
IElasticClientalbeit markedObsoletewith a message indicating what to rewrite the method invocation too.