Refactor ServerError, Error and ErrorCause #3677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With both the low level client and high level client now using the same internal serializer, the deserialization of ServerError, Error and ErrorCause can be simplified. ErrorCauseMetadata is removed from ErrorCause, and the properties it contains are hoisted onto ErrorCause. It is possible that the JSON for and error cause contains properties that are not mapped on ErrorCause. Currently, these will be ignored. If we fill it is worthwhile, we could also capture these.
Relates to elastic/elasticsearch#27672 I'd be +1 to rework |
Mpdreamz
approved these changes
Apr 17, 2019
| @@ -209,7 +209,7 @@ protected override void ExpectResponse(IDeleteByQueryResponse response) | |||
| failure.Id.Should().NotBeNullOrWhiteSpace(); | |||
|
|
|||
| failure.Cause.Should().NotBeNull(); | |||
| failure.Cause.IndexUniqueId.Should().NotBeNullOrWhiteSpace(); | |||
| failure.Cause.IndexUUID.Should().NotBeNullOrWhiteSpace(); | |||
This commit refactors Error and ErrorCause to deserialize known fields to properties and unknown properties into key/value pairs in AddtionalProperties.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With both the low level client and high level client now using the same internal serializer, the deserialization of
ServerError,ErrorandErrorCausecan be simplified.ErrorCauseMetadatais removed fromErrorCause, and the properties it contains are hoisted ontoErrorCause. It is possible that the JSON for and error cause contains properties that are not mapped onErrorCause. Currently, these will be ignored. If we feel it is worthwhile, we could also capture these too, by implementingErrorCauseas a dictionary with a formatter to deserialize and set known values