Deserialize relation on TotalHits #3667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit deserializes the relation and renames HitsTotal to TotalHits, line with Java source.
codebrain
reviewed
Apr 15, 2019
| } | ||
|
|
||
| return new TotalHits { Value = value, Relation = relation }; | ||
| case JsonToken.Number: |
There was a problem hiding this comment.
Mixed format response :(
There was a problem hiding this comment.
This is to handle rest_total_hits_as_int=true request parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deserializes the relation and renames
HitsTotaltoTotalHits, line with Java source.TotalHitsFormatterhandles both object and numeric representations ofTotalHits. When the value is numeric, no relation is present, and there is no simple way to determine what the relation should be. To handle this,Relationis of typeTotalHitsRelation?