Refactor/test version config #3649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russcam
approved these changes
Apr 10, 2019
build/scripts/Testing.fs
Outdated
| @@ -54,7 +53,10 @@ module Tests = | |||
| | (true) -> [ "--logger"; "trx"; "--collect"; "\"Code Coverage\""; "-v"; "m"] |> List.append command | |||
| | _ -> command | |||
|
|
|||
| Tooling.DotNet.ExecInWithTimeout "src/Tests/Tests" commandWithCodeCoverage (TimeSpan.FromMinutes 30.) | |||
| // using std redirection since that foces vstest not to redirect Console.Write from Elastic.Xunit somehow | |||
There was a problem hiding this comment.
Should this comment be updated with how vstest and xunit communicate?
There was a problem hiding this comment.
reverting this since Proc is not happy on linux
| /// </summary> | ||
| public bool ShowElasticsearchOutputAfterStarted { get; } = true; | ||
|
|
||
| /// <summary> When specified will only run one overload in API tests, helpful when debugging locally </summary> |
…on was a tad too complicated
…starting the tests this fix's vstest breaking console.writeline though I am not quite sure yet as to why
Mpdreamz
force-pushed
the
refactor/test-version-config
branch
from
41511e1
to
138a0b0
Compare
…ixed launching of cluster on command line not doing any bootstrap. Made environment config mode decision explicit rather then inferred based of NEST_INTEGRATION_VERSION
Mpdreamz
added a commit
that referenced
this pull request
Apr 17, 2019
* small fixes to how default versions are resolved and test configuration was a tad too complicated * refactor ITestConfiguration a bit further, use console redirect when starting the tests this fix's vstest breaking console.writeline though I am not quite sure yet as to why * Execute tests without standard redirection for now * AssertStatusCode called base.AssertResponse on SearchUsageTestBase, fixed launching of cluster on command line not doing any bootstrap. Made environment config mode decision explicit rather then inferred based of NEST_INTEGRATION_VERSION (cherry picked from commit 5403c8a)
|
ported to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ITestConfigurationand its implementations.