Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #3578 Add support for disabling id inference #3589

Merged
merged 2 commits into from
Mar 15, 2019

Conversation

Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented Mar 4, 2019

No description provided.

Copy link
Contributor

@russcam russcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I added some additional documentation.

I took the liberty of renaming DisableAllIdInference to DefaultDisableIdInference to align with other methods that set defaults.

@russcam
Copy link
Contributor

russcam commented Mar 15, 2019

@Mpdreamz if you're happy with the changes, I'll merge this one in

@Mpdreamz
Copy link
Member Author

Agree with the changes 👍

@russcam russcam merged commit e71bd68 into 6.x Mar 15, 2019
@russcam russcam deleted the feature/disable-id-inference-6.x branch March 27, 2019 03:40
russcam pushed a commit that referenced this pull request Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants