Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend query DSL with SpanFieldMaskingQuery #2231

Merged
merged 1 commit into from
Sep 12, 2016
Merged

Conversation

yevhen
Copy link

@yevhen yevhen commented Sep 1, 2016

Hi guys!

This commit extends query DSL with new very important query. More details could be found here and here.

This query is very important for us and I believe for many other people who use multifields or several fields to analyze text differently. We use 2 fields to analyze text - one with stemming and one as-is. This allows us to build very sophisticated queries for our scenarios.

It would be great if you accept it and push 1.9.1 soon.

Thanks in advance!

russcam added a commit that referenced this pull request Sep 6, 2016
russcam added a commit that referenced this pull request Sep 6, 2016
@Mpdreamz Mpdreamz merged commit 53797d1 into elastic:1.x Sep 12, 2016
Mpdreamz pushed a commit that referenced this pull request Sep 12, 2016
@yevhen
Copy link
Author

yevhen commented Sep 12, 2016

Oh, great. Thanks, guys! Can't wait for 1.9.1 👍

Mpdreamz added a commit that referenced this pull request Sep 12, 2016
As per elastic/elasticsearch#3007 this is now possible (before 1.x GA)

Added additional serialization tests
Mpdreamz pushed a commit that referenced this pull request Sep 12, 2016
Forward port of #2231
Conflicts:
	src/Nest/Nest.csproj
	src/Nest/QueryDsl/Abstractions/Container/QueryContainer-Assignments.cs
	src/Nest/QueryDsl/Query.cs
	src/Nest/QueryDsl/Visitor/QueryVisitor.cs
	src/Tests/Tests.csproj
@Mpdreamz
Copy link
Member

@yevhen thanks for submitting this to us! Totally not on our radar 👍

Pulled this in all active branches (1.x, 2.x and master) and added some additional unit tests in all branches.

I extended your PR slightly to also allow it to be used as a top level query

elastic/elasticsearch#3007

We'll do another 1.x release this week!

@yevhen
Copy link
Author

yevhen commented Sep 12, 2016

Awesome!

@yevhen
Copy link
Author

yevhen commented Sep 20, 2016

@Mpdreamz any updates for 1.9.1 release date?

@Mpdreamz
Copy link
Member

@yevhen we are looking to push a release out this week!

@Mpdreamz
Copy link
Member

I just see i said that one week ago as well 😞 so let me explain further:

We closed a couple of more issues against 1.x in the week since

#2191 GetIndex deserialization failure in 1.x
#2188 GetTemplate deserialization failure in 1.x
#2208 DateRange format support

and still have #2269 pending before we can do release.

@yevhen
Copy link
Author

yevhen commented Sep 20, 2016

Mmmm, #2269 look like a big effort. Is it a problem to release 1.9.1 and then 1.9.2 with #2269? We are facing problems with search functionality and need field masking query fix asap :(

@russcam
Copy link
Contributor

russcam commented Sep 21, 2016

@yevhen 1.9.1 is now released, including field_masking_span query. Thanks again for the PR 👍

@yevhen
Copy link
Author

yevhen commented Sep 21, 2016

oh, great! big thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants