-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JsonSerializerSettings not honored for Field Expressions #3926
Comments
Also the documentation for 7.x seems not updated yet? |
@KPStolk You are correct that some of the documentation needs to be updated to reflect that 7.x no longer ships with an internalized version of Json.NET. The use of NEST.JsonNetSerializer nuget package is still valid however. |
russcam
added a commit
that referenced
this issue
Jul 11, 2019
This commit fixes a bug introduced with Diagnostics Source support. DiagnosticsSerializerProxy does not implement IPropertyMappingProvider, so if it wraps and delegates to a serializer that does implement IPropertyMappingProvider, such as JsonNetSerialzer, this is not honoured when assigning to _propertyMappingProvider. This commit uses the sourceSerializer when determining _propertyMappingProvider, and not the DiagnosticsSerializerProxy. Fixes #3926
Opened #3942 to address |
russcam
added a commit
that referenced
this issue
Jul 12, 2019
) This commit fixes a bug introduced with Diagnostics Source support. DiagnosticsSerializerProxy does not implement IPropertyMappingProvider, so if it wraps and delegates to a serializer that does implement IPropertyMappingProvider, such as JsonNetSerialzer, this is not honoured when assigning to _propertyMappingProvider. This commit uses the sourceSerializer when determining _propertyMappingProvider, and not the DiagnosticsSerializerProxy. Fixes #3926
russcam
added a commit
that referenced
this issue
Jul 12, 2019
) This commit fixes a bug introduced with Diagnostics Source support. DiagnosticsSerializerProxy does not implement IPropertyMappingProvider, so if it wraps and delegates to a serializer that does implement IPropertyMappingProvider, such as JsonNetSerialzer, this is not honoured when assigning to _propertyMappingProvider. This commit uses the sourceSerializer when determining _propertyMappingProvider, and not the DiagnosticsSerializerProxy. Fixes #3926 (cherry picked from commit 8e6afad)
russcam
added a commit
that referenced
this issue
Jul 18, 2019
) This commit fixes a bug introduced with Diagnostics Source support. DiagnosticsSerializerProxy does not implement IPropertyMappingProvider, so if it wraps and delegates to a serializer that does implement IPropertyMappingProvider, such as JsonNetSerialzer, this is not honoured when assigning to _propertyMappingProvider. This commit uses the sourceSerializer when determining _propertyMappingProvider, and not the DiagnosticsSerializerProxy. Fixes #3926 (cherry picked from commit 8e6afad)
codebrain
pushed a commit
that referenced
this issue
Jul 19, 2019
) This commit fixes a bug introduced with Diagnostics Source support. DiagnosticsSerializerProxy does not implement IPropertyMappingProvider, so if it wraps and delegates to a serializer that does implement IPropertyMappingProvider, such as JsonNetSerialzer, this is not honoured when assigning to _propertyMappingProvider. This commit uses the sourceSerializer when determining _propertyMappingProvider, and not the DiagnosticsSerializerProxy. Fixes #3926 (cherry picked from commit 8e6afad)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
NEST/Elasticsearch.Net version:
7.0.1
NEST.JsonNetSerializer version:
7.0.1
Elasticsearch version:
7.2.0
Description of the problem including expected versus actual behavior:
Expected: be able to query on a field using an
Expression
lambda which should honor the[JsonProperty]
attributes when configured usingJsonSerializerSettings
just like in NEST 6.8.0.Actual: No query results are returned.
Steps to reproduce:
DELETE my-index
The poco model:
Timestamp
property name, not@timestamp
from the[JsonProperty]
attribute:The text was updated successfully, but these errors were encountered: