Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change HighlightFieldDictionary to use formatter #3852

Closed
codebrain opened this issue Jun 21, 2019 · 1 comment
Closed

Change HighlightFieldDictionary to use formatter #3852

codebrain opened this issue Jun 21, 2019 · 1 comment
Assignees
@russcam
Labels
Breaking

Comments

@codebrain
Copy link
Contributor

Change HighlightFieldDictionary to use formatter on Hit and deserialize into the Highlight property directly
@russcam russcam self-assigned this Jun 24, 2019
russcam added a commit that referenced this issue Jun 24, 2019
@russcam
Remove HighlightDocumentDictionary, HighlightHit
23fc36b 
This commit removes HighlightDocumentDictionary and HighlightHit. Both types provided little value over exposing highlights as a dictionary where each value is a collection of strings.

Closes #3852
@russcam russcam mentioned this issue Jun 24, 2019
Merged
Mpdreamz pushed a commit that referenced this issue Jun 24, 2019
@russcam @Mpdreamz
Remove HighlightDocumentDictionary, HighlightHit (#3864)
ddbbce9 
This commit removes HighlightDocumentDictionary and HighlightHit. Both types provided little value over exposing highlights as a dictionary where each value is a collection of strings.

Closes #3852
@russcam
Copy link
Contributor

russcam commented Jun 24, 2019

Closing as #3864 is merged

@russcam russcam closed this as completed Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@russcam russcam

Labels
Breaking
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@codebrain @russcam