Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added langchain document chunking notebook to nbtest #151

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Added langchain document chunking notebook to nbtest #151

merged 1 commit into from
Jan 22, 2024

Conversation

miguelgrinberg
Copy link
Collaborator

This PR includes:

  • minor changes to the langchain document chunking notebook to make it compatible with nbtest
  • cleanup logic for the above notebook
  • minor bugfix in nbtest that could sometimes cause a setup or teardown notebook to be tested as a main notebook
  • minor cleanups in a couple of other notebooks

@miguelgrinberg miguelgrinberg force-pushed the nbtest-langchain-chunking branch from b5e0528 to 995545f Compare January 10, 2024 12:14
@miguelgrinberg miguelgrinberg force-pushed the nbtest-langchain-chunking branch from 995545f to f2473e7 Compare January 18, 2024 17:11
@miguelgrinberg miguelgrinberg merged commit ebd2e96 into elastic:main Jan 22, 2024
1 check passed
@miguelgrinberg miguelgrinberg deleted the nbtest-langchain-chunking branch January 22, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joemcelroy joemcelroy Awaiting requested review from joemcelroy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@miguelgrinberg