Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.17] Refine BooleanEndpoint so that 4xx status codes other than 404 are considered as errors (#853) #856

Merged
merged 1 commit into from
Aug 6, 2024
Merged

[7.17] Refine BooleanEndpoint so that 4xx status codes other than 404 are considered as errors (#853) #856

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion java-client/src/main/java/co/elastic/clients/transport/endpoints/BooleanEndpoint.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ public BooleanEndpoint(

@Override
public boolean isError(int statusCode) {
return statusCode >= 500;
// 404 indicates a 'false' result.
return statusCode != 404 && super.isError(statusCode);
}

public boolean getResult(int statusCode) {
Expand Down
Loading