Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine BooleanEndpoint so that 4xx status codes other than 404 are considered as errors #853

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

swallez
Copy link
Member

@swallez swallez commented Aug 5, 2024

4xx errors other than 404 should throw an exception and not return a valid false result.

Fixes #850

@swallez swallez added Category: Bug Something isn't working backport 8.15 labels Aug 5, 2024
@swallez swallez requested a review from l-trotta August 5, 2024 16:07
@l-trotta l-trotta merged commit f28bcd5 into main Aug 6, 2024
9 checks passed
@l-trotta l-trotta deleted the boolean-endpoint-statuses branch August 6, 2024 09:07
github-actions bot pushed a commit that referenced this pull request Aug 6, 2024
swallez added a commit that referenced this pull request Aug 6, 2024
swallez added a commit that referenced this pull request Aug 6, 2024
swallez added a commit that referenced this pull request Aug 6, 2024
Copy link

github-actions bot commented Aug 6, 2024

The backport to 7.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.17 7.17
# Navigate to the new working tree
cd .worktrees/backport-7.17
# Create a new branch
git switch --create backport-853-to-7.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 f28bcd54451f309efd60b1fac6cda65a6dd346ab
# Push it to GitHub
git push --set-upstream origin backport-853-to-7.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.17

Then, create a pull request where the base branch is 7.17 and the compare/head branch is backport-853-to-7.17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants