Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder key-values in meta header to match other clients #334 #535

Merged
merged 4 commits into from
Apr 20, 2023

Conversation

Ankit-Khachane
Copy link
Contributor

@Ankit-Khachane Ankit-Khachane commented Mar 19, 2023

corrected the sequence for the CLIENT META VALUE sequence as mentioned in the description from the following link

Closes #334

@sethmlarson
Copy link
Contributor

jenkins test this please

@sethmlarson
Copy link
Contributor

sethmlarson commented Mar 20, 2023

@Ankit-Khachane Btw, in the future you can "link" a GitHub issue to close as soon as a PR is merged by adding "Closes #XYZ" to the PR description where XYZ is the issue number you want to link.

@Ankit-Khachane
Copy link
Contributor Author

Hi, @sethmlarson can you tell me when this PR changes will be merged in the main branch?

Copy link
Member

@swallez swallez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution!

@swallez swallez merged commit 356bdf8 into elastic:main Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reorder key-values in meta header to match other clients
3 participants