[DOCS] Add operation delete under the es.write.operation section #1959
Conversation
|
The delete operation is existing for a while but the current documentation is not representing that. #1324 |
|
@morland96 thanks for the PR! It does look like we just missed this after we added #1324. I've added a minor suggested change to bring it in line with the wording for |
Co-authored-by: Keith Massey <[email protected]>
Who will gonna execute the merge? Not sure about the workflow in this project. |
| @@ -159,6 +159,7 @@ The write operation {eh} should perform - can be any of: | |||
| `create`;; adds new data - if the data already exists (based on its id), an exception is thrown. | |||
| `update`;; updates existing data (based on its id). If no data is found, an exception is thrown. | |||
| `upsert`;; known as _merge_ or insert if the data does not exist, updates if the data exists (based on its id). | |||
| `delete`;; deletes existing data (based on its id). If no data is found, an exception is thrown. | |||
There was a problem hiding this comment.
If no data is found, an exception is thrown.
Maybe I am confusing what is meant with "data", but I am not getting an exception when deleting documents that are not in Elasticsearch.
Using "org.elasticsearch" %% "elasticsearch-spark-20" % 7.14.2
There was a problem hiding this comment.
PS: Which to me is preferable (having no exceptions) so that I am not obliged to read ES before
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
| @@ -159,6 +159,7 @@ The write operation {eh} should perform - can be any of: | |||
| `create`;; adds new data - if the data already exists (based on its id), an exception is thrown. | |||
| `update`;; updates existing data (based on its id). If no data is found, an exception is thrown. | |||
| `upsert`;; known as _merge_ or insert if the data does not exist, updates if the data exists (based on its id). | |||
| `delete`;; deletes existing data (based on its id). If no data is found, an exception is thrown. | |||
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Thank you for submitting a pull request!
Please make sure you have signed our Contributor License Agreement (CLA).
We are not asking you to assign copyright to us, but to give us the right to distribute your code without restriction. We ask this of all contributors in order to assure our users of the origin and continuing existence of the code.
You only need to sign the CLA once.