Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete operation backport to 7.4.2 #1492

Closed
wants to merge 1 commit into from

Conversation

krish2code
Copy link

@krish2code krish2code commented Jun 24, 2020

This PR is to backport delete support on version 7.4.2. Cherry-picked #1324 on top of 7.4.2 branch.

Thank you for submitting a pull request!

Please make sure you have signed our Contributor License Agreement (CLA).
We are not asking you to assign copyright to us, but to give us the right to distribute your code without restriction. We ask this of all contributors in order to assure our users of the origin and continuing existence of the code.
You only need to sign the CLA once.

This PR adds support for delete operations. Document ID's must be present for each document for this to work. A new bulk command factory has been added which will render a delete operation with the id and no document body in the bulk output.
@krish2code krish2code mentioned this pull request Jun 24, 2020
1 task
@krish2code
Copy link
Author

@jbaiera^^

@jbaiera
Copy link
Member

jbaiera commented Jun 26, 2020

Unfortunately the 7.4 branch will not see any more releases going forward. The current release line is 7.8.x, with 7.9 being the next minor. The change is already backported to 7.9 so it should be available when that version is released. Since the 7.4 branch is retired for development I'll close this PR out. Thanks for your questions though, and sorry again for the confusion!

@jbaiera jbaiera closed this Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants