Fix BlockAwareJsonParser level accounting #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The BlockAwareJsonParser is used to set a checkpoint on a JSON stream and exit the current blocks that the cursor is in back to the same level of the content that it was created at. If skipChildren is called to skip over an open array or object, the internal level counter will not be updated to account for the array or object that was skipped over. This PR updates the skipChildren method to check the currentToken and conditionally decrement the internal nested level counter if we ended up at an end of an array or object.
dakrone
approved these changes
Mar 18, 2020
Comment on lines
+188
to
+189
| // ^ ! |-------------^ | ||
| // ! = skipChildren |
jbaiera
added a commit
that referenced
this pull request
Mar 19, 2020
The BlockAwareJsonParser is used to set a checkpoint on a JSON stream and exit the current blocks that the cursor is in back to the same level of the content that it was created at. If skipChildren is called to skip over an open array or object, the internal level counter will not be updated to account for the array or object that was skipped over. This PR updates the skipChildren method to check the currentToken and conditionally decrement the internal nested level counter if we ended up at an end of an array or object.
jbaiera
added a commit
that referenced
this pull request
Mar 19, 2020
The BlockAwareJsonParser is used to set a checkpoint on a JSON stream and exit the current blocks that the cursor is in back to the same level of the content that it was created at. If skipChildren is called to skip over an open array or object, the internal level counter will not be updated to account for the array or object that was skipped over. This PR updates the skipChildren method to check the currentToken and conditionally decrement the internal nested level counter if we ended up at an end of an array or object.
jbaiera
added a commit
that referenced
this pull request
Mar 19, 2020
The BlockAwareJsonParser is used to set a checkpoint on a JSON stream and exit the current blocks that the cursor is in back to the same level of the content that it was created at. If skipChildren is called to skip over an open array or object, the internal level counter will not be updated to account for the array or object that was skipped over. This PR updates the skipChildren method to check the currentToken and conditionally decrement the internal nested level counter if we ended up at an end of an array or object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BlockAwareJsonParser is used to set a checkpoint on a JSON stream
and exit the current blocks that the cursor is in back to the same
level of the content that it was created at. If skipChildren is called
to skip over an open array or object, the internal level counter will
not be updated to account for the array or object that was skipped over.
This PR updates the skipChildren method to check the currentToken and
conditionally decrement the internal nested level counter if we ended
up at an end of an array or object.