Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usages of ClusterFormationTasks and replace with test clusters #1365

Merged
merged 2 commits into from
Oct 14, 2019

Conversation

mark-vieira
Copy link
Contributor

@mark-vieira mark-vieira commented Oct 11, 2019

This PR replaces all usages of ClusterFormationTasks with the new test clusters plugin since the former was removed in elastic/elasticsearch#47572.

Please note that this does depend on elastic/elasticsearch#47837 and builds will not start passing until that is merged and a new build-tools JAR is published.

I'm still seeing some test failures for the spark project integration tests. Any ideas @jbaiera?
https://gradle-enterprise.elastic.co/s/3bkbpjyn647ie

They all seem to be the same type of error:

org.elasticsearch.hadoop.rest.EsHadoopRemoteException: no handler found for uri [/defaulturiquerynopush_skiphandledspark-test-null-data-test-2/_doc/1/_source] and method [GET]

@mark-vieira mark-vieira requested a review from jbaiera October 11, 2019 21:44
@mark-vieira
Copy link
Contributor Author

mark-vieira commented Oct 11, 2019

Looks like the same "null value" tests are failing in master even with ClusterFormationTasks so I suspect they are unrelated to the refactoring.
https://gradle-enterprise.elastic.co/s/ppurjbiq66tz4/tests/failed

@jbaiera
Copy link
Member

jbaiera commented Oct 14, 2019

When I run ./gradlew clean build locally I'm getting:

FAILURE: Build failed with an exception.

* Where:
Build file '/Users/james.baiera/Documents/source/elasticsearch-hadoop/hive/build.gradle' line: 2

* What went wrong:
A problem occurred evaluating project ':elasticsearch-hadoop-hive'.
> Failed to apply plugin [class 'org.elasticsearch.gradle.DistributionDownloadPlugin']
   > Cannot get property 'bwcVersions' on extra properties extension as it does not exist

I don't have gradle scans set up yet but I can get one up if needed.

@mark-vieira
Copy link
Contributor Author

Sounds like the changes from elastic/elasticsearch#47837 haven't gone through yet.

Sounds like we might have a bit of a chicken/egg thing here. The stack release builds won't pass due to hadoop failing and hadoop wont' build due to the new build-tools jar not being published. We might have to discuss this with the release folks as I think publishing is an atomic operation, we either publish everything after a successful build or nothing.

@jbaiera
Copy link
Member

jbaiera commented Oct 14, 2019

Discussed off thread: I'll switch to using a snapshot of the current build tools from a local repo location. Should unblock the testing for this.

Kerberos project no longer needs to conditionally skip dependencies.
Skip license headers task since we do not have transitive build tools dependencies.
@jbaiera
Copy link
Member

jbaiera commented Oct 14, 2019

I've been able to verify that things are running well with the new test cluster plugin. LGTM!

@mark-vieira mark-vieira merged commit 301048e into elastic:master Oct 14, 2019
@colings86
Copy link

@mark-vieira Please remember to label all PRs with change type, area and version labels. This is important for the release notes process as well as letting people looking at the PR know quickly where it is targetting

@colings86
Copy link

I've added some labels I think are appropriate but please check and amend as necessary

@mark-vieira
Copy link
Contributor Author

@colings86 Thanks for doing that. Those labels look good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants