-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
async support #1714
Merged
Merged
async support #1714
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
05ebfa5
async support (work in progress)
miguelgrinberg 74eccd7
minor refactoring, fixed linter and docs
miguelgrinberg 8fcf16c
validate _sync directory during lint phase
miguelgrinberg 78a4f72
search unit tests
miguelgrinberg 5f9eb27
async support for Document class
miguelgrinberg db05fc2
search integration tests
miguelgrinberg 85a1f41
document tests
miguelgrinberg a0fb061
async support for Index class
miguelgrinberg a3fa07d
document integration tests
miguelgrinberg 326f965
remove unused mock dependency
miguelgrinberg 90c8eb5
unasync support for update_by_query
miguelgrinberg 071ddea
remove star imports
miguelgrinberg eca6306
unasync support for mapping.py
miguelgrinberg 73ffe5a
unasync index integration tests
miguelgrinberg 3690105
unasync faceted search
miguelgrinberg 0184a77
review imports for consistency
miguelgrinberg 8add69f
async support for analyzer
miguelgrinberg 4b7e9fb
async examples
miguelgrinberg 38cd862
examples integration tests
miguelgrinberg 7386dd5
restore sync examples unasynced by mistake
miguelgrinberg 8b5fa41
Documentation updates
miguelgrinberg 2468e8a
Review feedback
miguelgrinberg d06d804
more review feedback
miguelgrinberg 7bdf7dc
another batch of review updates
miguelgrinberg 9c8e63d
documentation reorg
miguelgrinberg c172281
more documentation improvements
miguelgrinberg 6b56fb3
unasyncing of examples
miguelgrinberg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few doubts about 1/ doing this for all files and not only examples and 2/ using a sed command carefully crafted to work on both Linux and macOS. This seems fragile, but it works, so let's do it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, 100% agree on the fragility. But I don't feel doing this for all files is a problem, since what we are doing is the correct thing to do as a general case. I could actually make the regex in the sed a bit smarter and capture the function name that is passed to
asyncio.run()
instead of having it hardcoded. I would think this type of transformation would make sense to add to unasync (although not with sed!).