Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return Elasticsearch warnings only in res.warnings #79

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Dec 8, 2023

Closes #33

I was not able to test this on a real cluster as:

  • elasticsearch-js does not expose warnings
  • I did not figure out how to use the transport client directly

But a way to test this is to run a ... 7.17 cluster and close an index:

curl -v -X PUT http://localhost:9200/test-index/
curl -v -X POST http://localhost:9200/test-index/_close

Or to run a 8.12 cluster and use GET _cat/aliases?local=true (elastic/elasticsearch#101815).

Copy link
Member

@JoshMock JoshMock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution @pquentin.

@JoshMock JoshMock merged commit 027a9d0 into elastic:main Dec 12, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

warnings() should not include warnings not originating from Elasticsearch
2 participants