Check allowed values for fields #771
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
|
|
||
| // ensureAllowedValues validates that the document's field value | ||
| // is one of the allowed values. | ||
| func ensureAllowedValues(key, value string, allowedValues AllowedValues) error { |
There was a problem hiding this comment.
nit: in theory, you don't need to pass key here as it's just used to render the error message :)
There was a problem hiding this comment.
Umm, but error message is rendered here, key is used in this function for that.
I would be fine with refactoring this error generation, but in a different PR, making the other ensure methods consistent with this.
|
Blocked till elastic/integrations#3016 is solved. |
🌐 Coverage report
|
jsoriano
force-pushed
the
check-allowed-values
branch
from
145a797 to
f40d122
Compare
|
I have moved the changes to check values in arrays to #835, so we can start benefiting of this in other cases as with IP validation (elastic/integrations#3408). |
|
Opening this for final review as blockers in elastic/integrations#3016 are close to be completed. @mtojek could you please take another look? |
Fields can include a list of allowed values. Check that the values of
these fields are between the allowed ones.
For arrays, validation is now done for all fields, as we not only need
to validate their type but also their values.
Part of #615.