Add GCP Cloud SDK to Terraform deployer image #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
mtojek
reviewed
Jan 10, 2022
| FROM python:3-alpine | ||
|
|
||
| # required by gcloud SDK | ||
| RUN apk add curl |
There was a problem hiding this comment.
also:
I checked here and there is also Git and OpenSSH installed in the original Docker image. Let's add them also to this custom one.
|
|
||
| COPY --from=terraform /bin/terraform /usr/bin/terraform | ||
|
|
||
| ENV TF_IN_AUTOMATION=true |
|
Hey @endorama! Please ping me when this PR is ready for another review round :) |
|
@mtojek Just updated with all requested changes! (Thanks for the ping, it slipped through ;)) |
Terraform deployer image may need some additional Cloud Service Provider specific tooling to handle corner cases not handled by Terraform itself. In this case this commits adds support for `bq` tool from GCP Cloud SDK. As `bq` and the entire GCP Cloud SDK requires python, is easy to add AWS or Azure dedicated tooling in the future (as both are Python-based).
4 tasks
mtojek
approved these changes
Jan 20, 2022
11 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terraform deployer image may need some additional Cloud Service Provider specific tooling to handle corner cases not handled by Terraform itself.
In this case this commits adds support for
bqtool from GCP Cloud SDK.As
bqand the entire GCP Cloud SDK requires python, is easy to add AWS or Azure dedicated tooling in the future (as both are Python-based).This PR is a follow-up for thread we started in https://github.com/elastic/integrations/pull/2312/files/f9557ea229de629c78ccb5d736efec2ab8ae104b#diff-6f3fb9692206fe5de2c5656d237ad692e6772234331ed60d7c91e674072d417e, where more CSP dedicated tools where needed in the Terraform deployer Docker image.