make backfill a positive duration

elastic · Dec 8, 2023 · 9017170 · 9017170
1 parent 52e3c59
commit 9017170
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/cmd/benchmark.go b/cmd/benchmark.go
@@ -410,7 +410,7 @@ func getStreamCommand() *cobra.Command {
 
 	cmd.Flags().StringP(cobraext.BenchNameFlagName, "", "", cobraext.BenchNameFlagDescription)
 	cmd.Flags().String(cobraext.VariantFlagName, "", cobraext.VariantFlagDescription)
-	cmd.Flags().DurationP(cobraext.BenchStreamBackFillFlagName, "", -15*time.Minute, cobraext.BenchStreamBackFillFlagDescription)
+	cmd.Flags().DurationP(cobraext.BenchStreamBackFillFlagName, "", 15*time.Minute, cobraext.BenchStreamBackFillFlagDescription)
 	cmd.Flags().Uint64P(cobraext.BenchStreamEventsPerPeriodFlagName, "", 10, cobraext.BenchStreamEventsPerPeriodFlagDescription)
 	cmd.Flags().DurationP(cobraext.BenchStreamPeriodDurationFlagName, "", 10*time.Second, cobraext.BenchStreamPeriodDurationFlagDescription)
 	cmd.Flags().BoolP(cobraext.BenchStreamPerformCleanupFlagName, "", false, cobraext.BenchStreamPerformCleanupFlagDescription)
@@ -437,8 +437,8 @@ func streamCommandAction(cmd *cobra.Command, args []string) error {
 		return cobraext.FlagParsingError(err, cobraext.BenchStreamBackFillFlagName)
 	}
 
-	if backFill > 0 {
-		return cobraext.FlagParsingError(errors.New("cannot be a positive duration"), cobraext.BenchStreamBackFillFlagName)
+	if backFill < 0 {
+		return cobraext.FlagParsingError(errors.New("cannot be a negative duration"), cobraext.BenchStreamBackFillFlagName)
 	}
 
 	eventsPerPeriod, err := cmd.Flags().GetUint64(cobraext.BenchStreamEventsPerPeriodFlagName)

diff --git a/internal/benchrunner/runners/stream/options.go b/internal/benchrunner/runners/stream/options.go
@@ -80,7 +80,7 @@ func WithProfile(p *profile.Profile) OptionFunc {
 
 func WithBackFill(d time.Duration) OptionFunc {
 	return func(opts *Options) {
-		opts.BackFill = d
+		opts.BackFill = -1 * d
 	}
 }
 

diff --git a/internal/cobraext/flags.go b/internal/cobraext/flags.go
@@ -66,7 +66,7 @@ const (
 	BenchCorpusRallyUseCorpusAtPathFlagDescription = "path of the corpus to use for the benchmark: if present no new corpus will be generated"
 
 	BenchStreamBackFillFlagName        = "backfill"
-	BenchStreamBackFillFlagDescription = "amount of time to ingest events for since starting from now: expressed as a negative duration"
+	BenchStreamBackFillFlagDescription = "amount of time to ingest events for, starting before now: expressed as a positive duration"
 
 	BenchStreamEventsPerPeriodFlagName        = "events-per-period"
 	BenchStreamEventsPerPeriodFlagDescription = "number of events to ingest at every ingestion cycle"