Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add @opentelemetry/instrumentation-winston instrumentation #35

Closed
4 tasks
david-luna opened this issue Jan 31, 2024 · 1 comment · Fixed by #117
Closed
4 tasks

feat: add @opentelemetry/instrumentation-winston instrumentation #35

david-luna opened this issue Jan 31, 2024 · 1 comment · Fixed by #117
Assignees
@trentm

Comments

@david-luna
Copy link
Member

david-luna commented Jan 31, 2024 •
edited
Loading

This is one of the instrumentations picked as part of the alpha version of the distro https://github.com/elastic/apm-nodejs-dev/issues/13#issuecomment-1917711771

Tasks

  • review the package and asses its quality to be included
  • add the instrumentation and discuss/decide config
  • create a sanity test for @opentelemetry/instrumentation-winston
  • ... add here anything that may be missing
@david-luna david-luna changed the title feat: add winston instrumentation feat: add @opentelemetry/instrumentation-winston instrumentation Jan 31, 2024
@trentm trentm added this to the alpha milestone Jan 31, 2024
@trentm trentm removed this from the alpha milestone Feb 1, 2024
@trentm
Copy link
Member

trentm commented Mar 26, 2024

  1. Waiting on a release after "@opentelemetry/instrumentation-winston": "^0.35.0", to have log sending support.
  2. Then optionally wait for or separately update expectations after [instrumentation-winston] LogRecord traceId and spanId values are not getting set correctly open-telemetry/opentelemetry-js-contrib#2010 is fixed for correct span context in the sent log records.

@trentm trentm self-assigned this Apr 2, 2024
trentm added a commit that referenced this issue Apr 5, 2024
@trentm
feat(otel-node): instrumentation for winston
5591de5 
Closes: #35
@trentm trentm mentioned this issue Apr 5, 2024
Merged
trentm added a commit that referenced this issue Apr 8, 2024
@trentm
feat(otel-node): instrumentation for winston (#117)
0bcb43b 
Note: the otel winston-transport package needs to be available for instr-winston to do log sending.
We are adding a dep on '@otel/winston-transport' and effectively 'winston-transport' here,
which differs from the vanilla NodeSDK and auto-instrumentations-node.

Closes: #35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trentm trentm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(otel-node): instrumentation for winston elastic/elastic-otel-node
2 participants
@trentm @david-luna