Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(partition): drilldown #995
feat(partition): drilldown #995
Changes from 4 commits
ea7404e
19d0fb0
c7ef1e0
ce53bf3
c17ed23
2c6abd6
ca796b1
cf1b3e2
71c7271
ab5b225
5ead490
7137cd0
7e32a70
e02960a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this is the best approach, though
SET_DRILLDOWN
) from within another action (ON_MOUSE_DOWN
), or redux "middleware" and error prone thunks etc.ON_MOUSE_DOWN
, eg. the callbacks registered for shape selections go through the same code path as beforeDisadvantages:
state.interactions
to the full globalstate
so it feels a bit more coupledIt seems possible to currently solve this via selectors, ie.
drilldown
wouldn't be a state property; it'd be a selector. ButI ran into this tradeoff with the Kibana Canvas layout engine, which is rich in inherently stateful direct manipulation interactions (stuff being dragged/resized, snapping etc.) and used an approach there that worked out quite well; it uses a global inert state like our redux, but has some differences: it solved the issue of one action arising from some other, lower level actions.