Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(partition): improving on chart events and callbacks #991

Merged
merged 15 commits into from
Jan 28, 2021
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: added model key
  • Loading branch information
monfera committed Jan 25, 2021
commit be1cb79d91116301b37ecd5640942dccd60f73d0
3 changes: 3 additions & 0 deletions api/charts.api.md
Original file line number Diff line number Diff line change
@@ -1195,6 +1195,9 @@ export function mergeWithDefaultAnnotationRect(config?: Partial<RectAnnotationSt
// @public
export function mergeWithDefaultTheme(theme: PartialTheme, defaultTheme?: Theme, axillaryThemes?: PartialTheme[]): Theme;

// @public (undocumented)
export const MODEL_KEY = "parent";

// Warning: (ae-missing-release-tag) "niceTimeFormatByDay" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
//
// @public (undocumented)
3 changes: 2 additions & 1 deletion src/chart_types/partition_chart/layout/types/types.ts
Original file line number Diff line number Diff line change
@@ -121,4 +121,5 @@ export interface Part extends Rectangle {
* - replace users' use of `s.parent` with `s[MODEL_KEY]` for the ShapeTreeNode -> ArrayNode access
* - change MODEL_KEY to something other than 'parent' when it's done (might still be breaking change)
*/
export const MODEL_KEY = 'whatever';
/** @public */
export const MODEL_KEY = 'parent';
1 change: 1 addition & 0 deletions src/index.ts
Original file line number Diff line number Diff line change
@@ -46,6 +46,7 @@ export {
export { Config as HeatmapConfig } from './chart_types/heatmap/layout/types/config_types';
export { Layer as PartitionLayer } from './chart_types/partition_chart/specs/index';
export { PrimitiveValue } from './chart_types/partition_chart/layout/utils/group_by_rollup';
export { MODEL_KEY } from './chart_types/partition_chart/layout/types/types';
export * from './chart_types/goal_chart/specs/index';
export {
Accessor,