Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: merge series domain with the domain of another group #912

Merged
merged 6 commits into from
Nov 24, 2020

Conversation

markov00
Copy link
Member

Summary

This PR will fix a regression that prevents the correct use of useDefaultGroupDomain.
It also includes a small feature that allows the consumer to specify a groupId on the same prop to allow merging the series domain with the domain of a different groupId.

@markov00 markov00 added bug Something isn't working enhancement New feature or request :data Data/series/scales related issue regression labels Nov 23, 2020
@markov00 markov00 requested a review from nickofthyme November 23, 2020 15:34
@codecov-io
Copy link

codecov-io commented Nov 23, 2020

Codecov Report

Merging #912 (38f8b61) into master (642abc0) will increase coverage by 0.62%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #912      +/-   ##
==========================================
+ Coverage   70.06%   70.68%   +0.62%     
==========================================
  Files         340      356      +16     
  Lines       10975    11272     +297     
  Branches     2373     2415      +42     
==========================================
+ Hits         7690     7968     +278     
- Misses       3271     3284      +13     
- Partials       14       20       +6     
Flag Coverage Δ
unittests 70.15% <93.75%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/chart_types/xy_chart/utils/specs.ts 100.00% <ø> (ø)
src/chart_types/xy_chart/state/utils/spec.ts 93.75% <80.00%> (-6.25%) ⬇️
src/chart_types/xy_chart/domains/y_domain.ts 95.74% <100.00%> (+12.25%) ⬆️
.../selectors/get_tooltip_values_highlighted_geoms.ts 90.78% <100.00%> (ø)
src/chart_types/xy_chart/state/utils/utils.ts 96.13% <100.00%> (ø)
src/mocks/utils.ts 100.00% <0.00%> (ø)
src/mocks/annotations/annotations.ts 73.33% <0.00%> (ø)
src/mocks/store/store.ts 92.59% <0.00%> (ø)
src/mocks/geometries.ts 92.10% <0.00%> (ø)
src/mocks/specs/specs.ts 82.95% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 642abc0...38f8b61. Read the comment docs.

Copy link
Collaborator

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tested locally, fixes the issue.

@markov00 markov00 merged commit 325b013 into elastic:master Nov 24, 2020
@markov00 markov00 deleted the 2020_11_23-fix_groupid_domain branch November 24, 2020 14:14
markov00 pushed a commit that referenced this pull request Nov 24, 2020
# [24.1.0](v24.0.0...v24.1.0) (2020-11-24)

### Bug Fixes

* **area_charts:** correctly represent baseline with negative data points ([#896](#896)) ([d1243f1](d1243f1))
* **legend:** legend sizes with ordinal data ([#867](#867)) ([7559e0d](7559e0d)), closes [#811](#811)
* render orphan data points on lines and areas ([#900](#900)) ([0be282b](0be282b)), closes [#783](#783)
* specs swaps correctly reflected in state ([#901](#901)) ([7fba882](7fba882))

### Features

* **legend:** allow legend text to be copyable ([#877](#877)) ([9cd3459](9cd3459)), closes [#710](#710)
* allow clearing series colors from memory ([#899](#899)) ([ab1af38](ab1af38))
* merge series domain with the domain of another group ([#912](#912)) ([325b013](325b013))
* small multiples for XY charts (alpha) ([#793](#793)) ([d288208](d288208)), closes [#500](#500) [#500](#500)
@markov00
Copy link
Member Author

🎉 This PR is included in version 24.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Nov 24, 2020
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
# [24.1.0](elastic/elastic-charts@v24.0.0...v24.1.0) (2020-11-24)

### Bug Fixes

* **area_charts:** correctly represent baseline with negative data points ([opensearch-project#896](elastic/elastic-charts#896)) ([b622fda](elastic/elastic-charts@b622fda))
* **legend:** legend sizes with ordinal data ([opensearch-project#867](elastic/elastic-charts#867)) ([74bcbad](elastic/elastic-charts@74bcbad)), closes [opensearch-project#811](elastic/elastic-charts#811)
* render orphan data points on lines and areas ([opensearch-project#900](elastic/elastic-charts#900)) ([3e2c739](elastic/elastic-charts@3e2c739)), closes [opensearch-project#783](elastic/elastic-charts#783)
* specs swaps correctly reflected in state ([opensearch-project#901](elastic/elastic-charts#901)) ([a94347f](elastic/elastic-charts@a94347f))

### Features

* **legend:** allow legend text to be copyable ([opensearch-project#877](elastic/elastic-charts#877)) ([21a96d3](elastic/elastic-charts@21a96d3)), closes [opensearch-project#710](elastic/elastic-charts#710)
* allow clearing series colors from memory ([opensearch-project#899](elastic/elastic-charts#899)) ([e97f4ab](elastic/elastic-charts@e97f4ab))
* merge series domain with the domain of another group ([opensearch-project#912](elastic/elastic-charts#912)) ([716ad5a](elastic/elastic-charts@716ad5a))
* small multiples for XY charts (alpha) ([opensearch-project#793](elastic/elastic-charts#793)) ([3b88e1c](elastic/elastic-charts@3b88e1c)), closes [opensearch-project#500](elastic/elastic-charts#500) [opensearch-project#500](elastic/elastic-charts#500)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working :data Data/series/scales related issue enhancement New feature or request regression released Issue released publicly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants