Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: near and far alignments for orthogonal rotations #911

Merged
merged 5 commits into from
Nov 24, 2020
Merged

fix: near and far alignments for orthogonal rotations #911

merged 5 commits into from
Nov 24, 2020

Conversation

nickofthyme
Copy link
Collaborator

Summary

fix #910

Improve axis label alignments for near and far with 0, 90, -90 and 180 rotations.

Screen Recording 2020-11-20 at 03 18 PM

Checklist

  • Any consumer-facing exports were added to src/index.ts (and stories only import from ../src except for test data & storybook)
  • Unit tests were updated or added to match the most common scenarios

@nickofthyme nickofthyme added the :axis Axis related issue label Nov 20, 2020
@nickofthyme nickofthyme requested a review from markov00 November 20, 2020 21:19
@nickofthyme nickofthyme changed the title Fix axis labels fix: near and far alignments for orthogonal rotations Nov 20, 2020
@codecov-io
Copy link

codecov-io commented Nov 20, 2020 •
edited
Loading

Codecov Report

Merging #911 (aee4096) into master (f99ba1f) will increase coverage by 0.48%.
The diff coverage is 42.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #911      +/-   ##
==========================================
+ Coverage   70.15%   70.64%   +0.48%     
==========================================
  Files         340      356      +16     
  Lines       10965    11286     +321     
  Branches     2371     2426      +55     
==========================================
+ Hits         7693     7973     +280     
- Misses       3258     3293      +35     
- Partials       14       20       +6
Flag Coverage Δ
unittests 70.11% <42.10%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
..._types/xy_chart/renderer/canvas/axes/tick_label.ts 21.73% <ø> (ø)
src/chart_types/xy_chart/utils/axis_utils.ts 89.79% <42.10%> (-2.31%) ⬇️
src/mocks/utils.ts 100.00% <0.00%> (ø)
src/mocks/specs/specs.ts 82.95% <0.00%> (ø)
src/mocks/scale/scale.ts 77.77% <0.00%> (ø)
src/mocks/theme.ts 100.00% <0.00%> (ø)
src/mocks/series/data.ts 100.00% <0.00%> (ø)
src/mocks/specs/index.ts 100.00% <0.00%> (ø)
src/mocks/scale/index.ts 100.00% <0.00%> (ø)
src/mocks/store/index.ts 100.00% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f99ba1f...aee4096. Read the comment docs.

@nickofthyme
Copy link
Collaborator Author

jenkins retest this please

markov00
markov00 approved these changes Nov 24, 2020
View reviewed changes
Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I've left a comment to improve a bit the typing, removing the cast that is not necessary

src/chart_types/xy_chart/renderer/canvas/axes/tick_label.ts Outdated Show resolved Hide resolved
src/chart_types/xy_chart/utils/axis_utils.ts Outdated Show resolved Hide resolved
@nickofthyme nickofthyme merged commit cb279f3 into elastic:master Nov 24, 2020
@nickofthyme nickofthyme deleted the fix-axis-labels branch November 24, 2020 18:42
markov00 pushed a commit that referenced this pull request Nov 25, 2020
@semantic-release-bot
chore(release): 24.2.0 [skip ci]
6bad227 
# [24.2.0](v24.1.0...v24.2.0) (2020-11-25)

### Bug Fixes

* near and far alignments for orthogonal rotations ([#911](#911)) ([cb279f3](cb279f3))

### Features

* add projection click listener ([#913](#913)) ([0fa9072](0fa9072)), closes [#846](#846)
@markov00
Copy link
Member

🎉 This PR is included in version 24.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Nov 25, 2020
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
@semantic-release-bot
chore(release): 24.2.0 [skip ci]
1d24233 
# [24.2.0](elastic/elastic-charts@v24.1.0...v24.2.0) (2020-11-25)

### Bug Fixes

* near and far alignments for orthogonal rotations ([opensearch-project#911](elastic/elastic-charts#911)) ([6b162c6](elastic/elastic-charts@6b162c6))

### Features

* add projection click listener ([opensearch-project#913](elastic/elastic-charts#913)) ([19c14e4](elastic/elastic-charts@19c14e4)), closes [opensearch-project#846](elastic/elastic-charts#846)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markov00 markov00 markov00 approved these changes

Assignees
No one assigned
Labels
:axis Axis related issue released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chart axis label alignment defaults with rotation
3 participants
@nickofthyme @codecov-io @markov00