fix: detect dragging only by the delta changes #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markov00
added
enhancement
darnautov
approved these changes
Oct 6, 2020
src/state/reducers/interactions.ts
Outdated
Comment on lines
66
to
68
| const dragging = !!( | ||
| state.pointer.down && getDelta(state.pointer.down.position, action.position) > DRAG_DETECTION_PIXEL_DELTA | ||
| ); |
There was a problem hiding this comment.
nit:
Suggested change
| const dragging = !!( | |
| state.pointer.down && getDelta(state.pointer.down.position, action.position) > DRAG_DETECTION_PIXEL_DELTA | |
| ); | |
| const dragging = !!state.pointer.down && getDelta(state.pointer.down.position, action.position) > DRAG_DETECTION_PIXEL_DELTA; |
|
🎉 This PR is included in version 23.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 23.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
## [23.2.1](elastic/elastic-charts@v23.2.0...v23.2.1) (2020-10-06) ### Bug Fixes * detect dragging only by the delta changes ([opensearch-project#853](elastic/elastic-charts#853)) ([7bf48bf](elastic/elastic-charts@7bf48bf)) * filter highlighted y values ([opensearch-project#855](elastic/elastic-charts#855)) ([1e99ccd](elastic/elastic-charts@1e99ccd))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fix changes the drag detection checking only the delta change between the mouse down position and the current mouse move removing the time check. This allows fast interaction used in CI functional tests without the need to add a delay between actions.