fix(axis): style overrides not applied to axis dimensions #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markov00
pushed a commit
that referenced
this pull request
Sep 21, 2020
## [21.3.2](v21.3.1...v21.3.2) (2020-09-21) ### Bug Fixes * **axis:** style overrides not applied to axis dimensions ([#829](#829)) ([62172c4](62172c4))
|
🎉 This PR is included in version 21.3.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
1 task
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
## [21.3.2](elastic/elastic-charts@v21.3.1...v21.3.2) (2020-09-21) ### Bug Fixes * **axis:** style overrides not applied to axis dimensions ([#829](elastic/elastic-charts#829)) ([f57e39b](elastic/elastic-charts@f57e39b))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After improvements from #711, the axis theme was allowed to be overridden per axis. These changes failed to account for these overrides in the
computeAxisTicksDimensionsSelectorand just used theTheme.axisstyles.This PR adds the overrides to the axis dimensions calculations.
Before
After
Checklist
src/index.ts(and stories only import from../srcexcept for test data & storybook)