Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(axes): correctly remove only consecutive duplicated ticks #742

Merged
merged 3 commits into from
Jul 7, 2020
Merged

fix(axes): correctly remove only consecutive duplicated ticks #742

merged 3 commits into from
Jul 7, 2020

Conversation

markov00
Copy link
Member

@markov00 markov00 commented Jul 7, 2020

Summary

This commit fixes the current behavior of the duplicated ticks handling the removal only for
consecutive duplicated ticks"

From this wrongly represented axis:
Screenshot 2020-07-07 at 16 38 28

To a correctly de-duplicated axis:
Screenshot 2020-07-07 at 16 38 08

fix #667

Checklist

  • Proper documentation or storybook story was added for features that require explanation or tutorials
  • Unit tests were updated or added to match the most common scenarios

@markov00
fix(axes): correctly remove only consecutive duplicated ticks
580b12c 
This commit fix the current behaviour of the duplicated ticks handling the removal only for
consecutive duplicated ticks"

fix elastic#667
@markov00 markov00 added bug Something isn't working :axis Axis related issue labels Jul 7, 2020
@markov00 markov00 merged commit 5038a63 into elastic:master Jul 7, 2020
@markov00 markov00 deleted the 2020_07_07-fix_consecutive_dupolicated_ticks branch July 7, 2020 15:40
markov00 pushed a commit that referenced this pull request Jul 7, 2020
@semantic-release-bot
chore(release): 19.8.1 [skip ci]
0a0860c 
## [19.8.1](v19.8.0...v19.8.1) (2020-07-07)

### Bug Fixes

* **axes:** remove only consecutive duplicated ticks ([#742](#742)) ([5038a63](5038a63)), closes [#667](#667)
@markov00
Copy link
Member Author

markov00 commented Jul 7, 2020

🎉 This PR is included in version 19.8.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Jul 7, 2020
@markov00 markov00 mentioned this pull request Jul 7, 2020
Merged
1 task
@markov00
Copy link
Member Author

🎉 This PR is included in version 19.8.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
@semantic-release-bot
chore(release): 19.8.1 [skip ci]
2c0ddd3 
## [19.8.1](elastic/elastic-charts@v19.8.0...v19.8.1) (2020-07-07)

### Bug Fixes

* **axes:** remove only consecutive duplicated ticks ([opensearch-project#742](elastic/elastic-charts#742)) ([1d4fddc](elastic/elastic-charts@1d4fddc)), closes [opensearch-project#667](elastic/elastic-charts#667)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickofthyme nickofthyme nickofthyme left review comments

Assignees
No one assigned
Labels
:axis Axis related issue bug Something isn't working released on @19.8.x released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Smarter duplicate ticks finder
2 participants
@markov00 @nickofthyme