fix: redux connect issue related to spec upserting #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickofthyme
changed the title
Codecov Report
@@ Coverage Diff @@
## master #563 +/- ##
=========================================
Coverage ? 71.59%
=========================================
Files ? 212
Lines ? 6137
Branches ? 1175
=========================================
Hits ? 4394
Misses ? 1724
Partials ? 19
Continue to review full report at Codecov.
|
nickofthyme
added a commit
to nickofthyme/elastic-charts
that referenced
this pull request
Feb 21, 2020
nickofthyme
added a commit
to nickofthyme/elastic-charts
that referenced
this pull request
Feb 21, 2020
nickofthyme
added a commit
to nickofthyme/elastic-charts
that referenced
this pull request
Feb 21, 2020
markov00
pushed a commit
that referenced
this pull request
Feb 21, 2020
## [17.1.1](v17.1.0...v17.1.1) (2020-02-21) ### Bug Fixes * redux connect memo issue related to spec upserting ([#563](#563)) ([f3a05f1](f3a05f1))
9 tasks
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
## [17.1.1](elastic/elastic-charts@v17.1.0...v17.1.1) (2020-02-21) ### Bug Fixes * redux connect memo issue related to spec upserting ([opensearch-project#563](elastic/elastic-charts#563)) ([138b769](elastic/elastic-charts@138b769))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix issue with redux state clearing specs after consumer state update.
The redux chart state requires all specs are called every time the
Chartcomponent is updated. This was not happening due to the pure option that defaults to false, basically creating a shallow equal ormemoreact component.Checklist