chore: tighter partition types #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #560 +/- ##
==========================================
+ Coverage 71.83% 72.02% +0.19%
==========================================
Files 201 212 +11
Lines 6042 6187 +145
Branches 1170 1188 +18
==========================================
+ Hits 4340 4456 +116
- Misses 1684 1712 +28
- Partials 18 19 +1
Continue to review full report at Codecov.
|
markov00
force-pushed
the
tighter-partition-types
branch
from
f9f2b99 to
8c32e44
Compare
nickofthyme
approved these changes
Feb 28, 2020
Comment on lines
669
to
689
| expect(datum!.y1).toBe(1); | ||
| expect(datum!.y0).toBe(2); | ||
| datum = cleanDatum([0, '1', 2], 0, 1, 2); | ||
| expect(datum.y1).toBe(1); | ||
| expect(datum.y0).toBe(2); | ||
| expect(datum).toBeDefined(); | ||
| expect(datum!.y1).toBe(1); | ||
| expect(datum!.y0).toBe(2); | ||
|
|
||
| datum = cleanDatum([0, '1', '2'], 0, 1, 2); | ||
| expect(datum.y1).toBe(1); | ||
| expect(datum.y0).toBe(2); | ||
| expect(datum).toBeDefined(); | ||
| expect(datum!.y1).toBe(1); | ||
| expect(datum!.y0).toBe(2); | ||
|
|
||
| datum = cleanDatum([0, 1, '2'], 0, 1, 2); | ||
| expect(datum.y1).toBe(1); | ||
| expect(datum.y0).toBe(2); | ||
| expect(datum).toBeDefined(); | ||
| expect(datum!.y1).toBe(1); | ||
| expect(datum!.y0).toBe(2); | ||
|
|
||
| datum = cleanDatum([0, 'invalid', 'invalid'], 0, 1, 2); | ||
| expect(datum.y1).toBe(null); | ||
| expect(datum.y0).toBe(null); | ||
| expect(datum).toBeDefined(); | ||
| expect(datum!.y1).toBe(null); | ||
| expect(datum!.y0).toBe(null); |
There was a problem hiding this comment.
Using a ? would be the same here. I don't like !
expect(datum?.y1).toBe(1);
markov00
added a commit
that referenced
this pull request
Mar 2, 2020
Tightens up partitioning chart types. BREAKING CHANGES: The `valueFormatter` prop function now receive only a `number` instead of `any`. In the layers props the `nodeLabel` is now typed as `(d: PrimitiveValue) => String(d)` where `PrimitiveValue` is `string | number | null`. The `fillColor` of a `shape` has a tighter type: `(d: ShapeTreeNode, index: number, array: HierarchyOfArrays) => string` Co-authored-by: Marco Vettorello <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Tightens up partitioning chart types, as several was, in effect,
any. See point 3 in #518 (comment)It's a breaking change as it may need that client libraries update types, even though there's no runtime change.
BREAKING CHANGES:
The
valueFormatterprop function now receive only anumberinstead ofany.In the
layersprops:nodeLabelis now typed as(d: PrimitiveValue) => String(d),wherePrimitiveValueisstring | number | null.fillColorof ashapehas a tighter type:(d: ShapeTreeNode, index: number, array: HierarchyOfArrays) => string;Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.Any consumer-facing exports were added tosrc/index.ts(and stories only import from../srcexcept for test data & storybook)Unit tests were updated or added to match the most common scenarios