Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move seedrandom to dependency list #423

Closed
wants to merge 1 commit into from

Conversation

markov00
Copy link
Member

Summary

We are shipping the project with seedrandom as devDependency.
Since this is used in DataGenerator that is exposed as public module we should move the seedrandom devDependency to the dependency list.

see Jenkins errors in Kibana: https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/5354/console and the updating PR: elastic/kibana#47939

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

  • Any consumer-facing exports were added to src/index.ts (and stories only import from ../src except for test data & storybook)
  • [ ] This was checked for cross-browser compatibility, including a check against IE11
  • [ ] Proper documentation or storybook story was added for features that require explanation or tutorials
  • [ ] Unit tests were updated or added to match the most common scenarios
  • Each commit follows the convention

@codecov-io
Copy link

codecov-io commented Oct 17, 2019

Codecov Report

Merging #423 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #423   +/-   ##
=======================================
  Coverage   97.85%   97.85%           
=======================================
  Files          39       39           
  Lines        2896     2896           
  Branches      701      701           
=======================================
  Hits         2834     2834           
  Misses         55       55           
  Partials        7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22baa00...eb3a416. Read the comment docs.

@markov00
Copy link
Member Author

close in favour of #424

@markov00 markov00 closed this Oct 17, 2019
@markov00 markov00 deleted the fix-deps branch October 17, 2019 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants